BUG: String indexing against object dtype may raise AttributeError #14424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Bug
Indexing
Current coverage is 85.25% (diff: 100%)@@ master #14424 diff @@
==========================================
Files 140 140
Lines 50631 50632 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43167 43168 +1
Misses 7464 7464
Partials 0 0
|
| @@ -2936,6 +2936,9 @@ def _wrap_joined_index(self, joined, other): | |||
| name = self.name if self.name == other.name else None | |||
| return Index(joined, name=name) | |||
|
|
|||
| def _get_string_slice(self, key, use_lhs=True, use_rhs=True): | |||
There was a problem hiding this comment.
Can you add a docstring or comment explaining where this is overwritten / used ?
There was a problem hiding this comment.
sure, added the comment.
|
Small comment, looks good for the rest |
sinhrks
force-pushed
the
partial_string_bug
branch
from
a1ebe40 to
ae22dce
Compare
jorisvandenbossche
approved these changes
Oct 17, 2016
|
@sinhrks Thanks! |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Nov 2, 2016
… may raise AttributeError (pandas-dev#14424) (cherry picked from commit 233d51d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffString indexing may raise
AttributeError, rather thanKeyError.